Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(opening a draft PR in case someone wants to help bring this to completion)
This PR adds most of the bessel functions to rascaline, porting them from scipy/cephes. These functions will be needed for a native implementation of the LE basis, and to implement numerical integration in the radial integral.
The main thing missing is a set of tests for the
jv
andyv
bessel functions, for input values all over the range where these functions are defined, and triple checking around any poles/special points.